Skip to content

Commit

Permalink
Merge pull request #54 from jutley/acl-goroutine-leak
Browse files Browse the repository at this point in the history
Update acl controller to cache the client
  • Loading branch information
marshmallory authored Feb 3, 2023
2 parents 24fed20 + abaca50 commit 7bcd534
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions internal/controller/acl/acl.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ func Setup(mgr ctrl.Manager, l logging.Logger) error {
managed.WithExternalConnectDisconnecter(&connectDisconnector{
kube: mgr.GetClient(),
usage: resource.NewProviderConfigUsageTracker(mgr.GetClient(), &apisv1alpha1.ProviderConfigUsage{}),
log: l,
newServiceFn: kafka.NewAdminClient}),
managed.WithLogger(l.WithValues("controller", name)),
managed.WithRecorder(event.NewAPIRecorder(mgr.GetEventRecorderFor(name))),
Expand Down Expand Up @@ -120,6 +121,7 @@ func (c *connectDisconnector) Connect(ctx context.Context, mg resource.Managed)
if err != nil {
return nil, errors.Wrap(err, errNewClient)
}
c.cachedClient = svc

return &external{kafkaClient: svc, log: c.log}, nil
}
Expand Down

0 comments on commit 7bcd534

Please sign in to comment.