Shutdown gracefully on SIGTERM #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file wasn't formatted before making it into main. Not sure why the linter didn't catch it... Signed-off-by: Nic Cope <[email protected]>
Signed-off-by: Nic Cope <[email protected]>
|
Hi, indeed this looks cleaner than what I did. I still get an error with the lambda which apparently is given 2 positional arguments (that's why I set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #109
Closes #130
@fernandezcuesta I did a bit of research while reviewing #130 and came across this pattern. What do you think? I still need to test it and see if it actually works.
I have:
Added or updated unit tests for my change.