Skip to content

Problem: tx is not replaced by priority #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Problem: tx is not replaced by priority #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

* (evm) [#414](https://github.com/crypto-org-chain/ethermint/pull/414) Integrate go-block-stm for parallel tx execution.
* (block-stm) [#498](https://github.com/crypto-org-chain/ethermint/pull/498) Enable incarnation cache for block-stm executor.
* (app) [#]() Only replace tx if new priority is larger.

### State Machine Breaking

Expand Down
4 changes: 4 additions & 0 deletions app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,10 @@
TxPriority: mempool.NewDefaultTxPriority(),
SignerExtractor: NewEthSignerExtractionAdapter(mempool.NewDefaultSignerExtractionAdapter()),
MaxTx: maxTxs,
TxReplacement: func(op, np int64, oTx, nTx sdk.Tx) bool {

Check warning on line 283 in app/app.go

View workflow job for this annotation

GitHub Actions / Run golangci-lint 

unused-parameter: parameter 'oTx' seems to be unused, consider removing or renaming it as _ (revive)
// tx is only replaced if new priority is higher than old priority
return np > op
},

Check warning on line 286 in app/app.go

View check run for this annotation

Codecov / codecov/patch

app/app.go#L285-L286 

Added lines #L285 - L286 were not covered by tests
})
handler := baseapp.NewDefaultProposalHandler(mempool, app)

Expand Down
Loading