feat: Support buffered fallback for ImageMagick #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vips_image_new_from_source doesn't appear to work in combination with the libvips ImageMagick loader. However, vips_image_new_from_file does. These changes add support for a buffered fallback if libvips fails to load the blob as a source and the blob is of unknown type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vips_image_new_from_sourcedoesn't appear to work in combination with the libvips ImageMagick loader. However,vips_image_new_from_filedoes.I stumbled on this while testing imagor on newer RAW camera files, like the CR3 file found here. Without these changes,
libvipsfails to load the images. With the changes, it succeeds.At a high level, this adds support for a buffered-file fallback if
libvipsfails to load the blob as a source and the blob is of unknown type. The file is kept only long enough to create the Image.I tried a few different ways to do this, but this felt the least intrusive. I'm happy to try a different approach if you feel there is a better insertion point.