inconsistency with css-loader

[deanshub]

the regex at this line breaks consistency with css-loader generation getLocalIdent

the test case is @ in node modules, scoping packages is getting popular and when we use the same parameters (localindentname, hashprefix,...) with requiring css from a node module that has @ in it, generic-names replaces it with - but css-loader leaves it as @

That's because, \u00A0-\uFFFF doesn't contain @

[benmvp]

I'm having a similar problem, but w/ a different line of code. 😄

This PR changed the content being passed to interpolateName (in loader-utils) from including a plus + to including \x00. This is now in css-loader >= 4. However, generic-names still using + so there's now an inconsistency in how the class names are generated.

Given that this library is basically piggybacking on what webpack does, it seems like it should be updated to match. I already asked in css-loader and the change was intentional (webpack-contrib/css-loader#1214).

The actual problem I'm having is with babel-plugin-react-css-modules which uses this package to generate the class names. See: gajus/babel-plugin-react-css-modules#291

[benmvp]

@evilebottnawi is this something that can be changed here then?

[alexander-akait]

Why do you need generic-names?

[benmvp]

@evilebottnawi - babel-plugin-react-css-modules uses generic-names in order to generate its scoped names. And since generic-names no longer uses the same format as css-loader v4+ (see above), babel-plugin-react-css-modules is broken with css-loader v4+.

Here's the open issue: gajus/babel-plugin-react-css-modules#291

[alexander-akait]

@benmvp You can send a PR

[alexander-akait]

Just copy logic from css-loader to here

[benmvp]

Cool, that was my plan, but wanted to make sure you were ok with it.

[alexander-akait]

👍