Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR changed the
content
being passed tointerpolateName
(inloader-utils
) from including a plus+
to including\x00
. This is now incss-loader
>= 4. However,generic-names
still using+
so there's now an inconsistency in how the class names are generated.Given that this library is basically piggybacking on what webpack does, it should be updated to match.
This caused
babel-plugin-react-css-modules
to break: gajus/babel-plugin-react-css-modules#291Solution
Use
\x00
instead of+
and update the tests.Fixes #8.
BREAKING CHANGE: This change will result in new names being generated, particularly those using
[hash]
. You will need to upgrade tocss-loader
>= 4 if you are wanting to keep the classes in sync.