Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed docker-image to alpine #915

Merged
merged 1 commit into from
May 2, 2021

Conversation

Cyber1000
Copy link
Contributor

The issues I linked here may be closed after merging, since all relevant info is said and/or problems got fixed

@Cyber1000
Copy link
Contributor Author

This may also fix (or at least make troubleshooting easier) - whoever had this problems, please check after merging:

@Cyber1000
Copy link
Contributor Author

Note to myself:

  • this image should work with podman - testing myself on fedora, if positive PR adds podman support #732 may be obsolete (@ohadlevy may test this too after merging this PR)
  • this PR adds a switch for different OSes: Arch Linux support for install_prereq.sh #890 - After this is merged I would add a switch for alpine OS, to get everything for setting up a host or docker into install_prereq.sh. For now the setup is kept within Dockerfile. To make the correct switch-statement: The ID is alpine in /etc/os-release

@Daveyr
Copy link

Daveyr commented Mar 8, 2021

This might also fix #922, where I can't use the base image on a Raspberry Pi 4. Alpine supports armv7 so in theory it should run fine.

@kueblc
Copy link
Collaborator

kueblc commented Mar 12, 2021

@Cyber1000 @ohadlevy @aravindkoneru

Thank you all for your contributions! I apologize for the delay getting back to this.

Since I am not at all familiar with Docker, can you please let me know which of #732, #915, #923 is ready for merge and which are obsolete/redundant?

@Cyber1000
Copy link
Contributor Author

Sorry my time was limited too due to heavy work load

#923 -> does exactly the same as this PR (#915), but #915 does a little bit more (especially using alpine as base which can be used on raspberry os too)
#732 -> uses fedora-minimal which won't work on raspberry os. I haven't tested my new docker on fedora (no time/no WLAN-Interface on my fedora machine), so someone may try it. Anyway it it safe to merge #732, it just is an alternative Dockerfile named Dockerfile.fedora, which doesn't get used automatically, you would have to include it in your yml (or overwrite the original Dockerfile) to use it - we may add something to the README if we merge this

@kueblc kueblc merged commit 6281d83 into ct-Open-Source:development May 2, 2021
@kueblc
Copy link
Collaborator

kueblc commented May 2, 2021

Sorry for the delay! Day jobs...

@Cyber1000 Cyber1000 deleted the development branch May 8, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants