Skip to content
Draft
Show file tree
Hide file tree
Changes from 61 commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
8b61a19
:Initial commit
Hckjs Dec 11, 2024
b5e25a8
Not working draft
Hckjs Dec 16, 2024
83d394d
Adding eventwise stereo calculation
Hckjs Feb 21, 2025
35d173b
small typo
Hckjs Feb 21, 2025
3711ad0
Rename function name
Hckjs Feb 27, 2025
f02d857
Upgrade jited function
Hckjs Feb 27, 2025
a5e4751
Keep structure of Combiners
Hckjs Feb 28, 2025
52f8766
Add unit test for single event
Hckjs Mar 10, 2025
09d4600
Working on table prediction
Hckjs Mar 12, 2025
a5dee6c
rewrite get_index_combs
Hckjs Mar 13, 2025
40ddc09
Adding functions for tablewise prediction
Hckjs Mar 14, 2025
02ec3f6
Fix for single telescope events
Hckjs Mar 17, 2025
08999d2
Fix unit test
Hckjs Mar 17, 2025
3785663
Rename variable
Hckjs Mar 19, 2025
7651980
Fix for single tel arrays
Hckjs Mar 26, 2025
4f8396a
Implement njit version
Hckjs Mar 27, 2025
efb1e4c
Add docstrings
Hckjs Apr 1, 2025
2265333
Some renamings
Hckjs Apr 2, 2025
ad1f2b3
Adding some unit tests
Hckjs Apr 4, 2025
0bd48bf
Switching to np.argmin
Hckjs Apr 4, 2025
9a95cd0
Extend apply-tool hack to prefix for now
LukasBeiske May 18, 2025
75a0076
Add sign_score as weighting for minimum distance calculation
Hckjs Nov 5, 2025
5efd46a
Adapt unit test
Hckjs Nov 5, 2025
183ad40
Undo apply_models tool hack
Hckjs Nov 5, 2025
de94195
generalize create_combs_array
Hckjs Nov 5, 2025
71ce973
Switch n_tel_combinations to instance attribute
Hckjs Nov 5, 2025
91f6286
Fix small bug
Hckjs Nov 5, 2025
86f32b1
Allow None for sign_score_limit
Hckjs Nov 25, 2025
3e38222
Remove property check in call and predict_table
Hckjs Nov 25, 2025
9569555
Add docstrings
Hckjs Nov 25, 2025
eda64bb
Check that DispReconstructor was used
Hckjs Nov 25, 2025
23fbe14
Adapt get_combinations
Hckjs Nov 25, 2025
1f93c7c
fix calc_combs_min_distances unit tests
Hckjs Nov 25, 2025
ac57da2
Fix calc_fov_lon_lat unit test
Hckjs Nov 25, 2025
e070e57
Fix docstring citation
Hckjs Nov 26, 2025
0c77030
Add changelog
Hckjs Nov 26, 2025
257d4a9
Add combiner to reco __init__
Hckjs Nov 26, 2025
1bbe08f
Fix indentation in changelog
Hckjs Nov 26, 2025
0d1013e
disp to_value and precompute abs(disp)
Hckjs Dec 9, 2025
2eba76a
Add single tel events handling in event loop
Hckjs Dec 9, 2025
69f48e6
Reduce cognitive complexity
Hckjs Dec 9, 2025
19fe57b
Add calc_weights function to parent class
Hckjs Dec 9, 2025
9702cb7
Switch to COPY_IF_NEEDED
Hckjs Dec 9, 2025
5aa93d4
rename konrad weights
Hckjs Jan 29, 2026
897ff67
Add njit option to disable numba cache
Hckjs Jan 29, 2026
70622b2
Explicitly check for ImageParametersContainer in calc_weights
Hckjs Jan 29, 2026
b2c698b
Remove sign_score_limit and all its dependencies
Hckjs Jan 29, 2026
a7db32d
Generalize algorithm to use configurable n_tel_combinations
Hckjs Jan 30, 2026
def846e
Add min_angle_diff for nearly parallel main shower axes
Hckjs Jan 30, 2026
25d8af8
Add n_best_tels option in table-wise processing
Hckjs Jan 31, 2026
5276aa9
add property trait with config=False
Hckjs Feb 1, 2026
05f3259
outsource check_ang_diff
Hckjs Feb 1, 2026
ddccfca
Update docstrings
Hckjs Feb 1, 2026
c95eaf8
Add StereoQualityQuery
Hckjs Feb 2, 2026
7762ac3
Adapt disp container check
Hckjs Feb 2, 2026
4877358
Update unit-tests
Hckjs Feb 3, 2026
3f3d157
Adapt trait test
Hckjs Feb 3, 2026
4ef0dd7
Update docstrings
Hckjs Feb 3, 2026
0a12334
Fix empty table handling
Hckjs Feb 3, 2026
a868cba
Handle empty tables in add_defaults_and_meta
Hckjs Feb 3, 2026
c1ba500
Refactoring
Hckjs Feb 3, 2026
025da2d
Adress comments
Hckjs Feb 4, 2026
f7affac
Switch from take_along_axis to linear blend (bit faster)
Hckjs Feb 4, 2026
ebb6ace
Update changelog
Hckjs Feb 4, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/changes/2731.feature.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Add a ``StereoDispCombiner`` implementing DISP-based stereo direction reconstruction.

Adapted from the implementation in magic-cta-pipe and EventDisplay, it combines
mono DISP reconstruction by:
- get combinations of 2 telescope for every array event
- calculating the minimum distance for the 4 possible SIGN pairs for each combination
- DISP sign score can be optionally used to weight the distances
- calculating the weighted average for the minimum distance SIGN pair (fov lon/lat) per combination
- calculating the weighted average of all combinations for an array event with the summed weights
2 changes: 1 addition & 1 deletion src/ctapipe/image/statistics.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def descriptive_statistics(
)


@njit
@njit(cache=not CTAPIPE_DISABLE_NUMBA_CACHE)
def n_largest(n, array):
"""return the n largest values of an array"""
return nlargest(n, array)
Expand Down
3 changes: 2 additions & 1 deletion src/ctapipe/reco/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
EnergyRegressor,
ParticleClassifier,
)
from .stereo_combination import StereoCombiner, StereoMeanCombiner
from .stereo_combination import StereoCombiner, StereoDispCombiner, StereoMeanCombiner

__all__ = [
"Reconstructor",
Expand All @@ -32,5 +32,6 @@
"DispReconstructor",
"StereoCombiner",
"StereoMeanCombiner",
"StereoDispCombiner",
"CrossValidator",
]
Loading
Loading