Skip to content

Allow eventio 2.0#2857

Merged
maxnoe merged 6 commits into
mainfrom
eventio2-compat
Nov 12, 2025
Merged

Allow eventio 2.0#2857
maxnoe merged 6 commits into
mainfrom
eventio2-compat

Conversation

@maxnoe
Copy link
Copy Markdown
Member

@maxnoe maxnoe commented Oct 10, 2025

New start for updating to eventio 2.0, easier than resolving merge conflicts.

I'll make the minimal changes here to add compatibility and make a separate PR to actually enable the new "iter all events" option.

@maxnoe maxnoe marked this pull request as draft October 10, 2025 14:17
@maxnoe maxnoe force-pushed the eventio2-compat branch 4 times, most recently from 5b8f917 to 00c1992 Compare October 10, 2025 15:41
@maxnoe maxnoe marked this pull request as ready for review October 10, 2025 15:44
@ctao-sonarqube
Copy link
Copy Markdown

ctao-sonarqube Bot commented Oct 10, 2025

@maxnoe maxnoe requested review from kosack and mdebony October 14, 2025 09:05
@maxnoe
Copy link
Copy Markdown
Member Author

maxnoe commented Oct 24, 2025

@kosack @mdebony

Could you review here?

@maxnoe maxnoe added this to the v0.28.0 milestone Nov 10, 2025
kosack
kosack previously approved these changes Nov 10, 2025
@maxnoe
Copy link
Copy Markdown
Member Author

maxnoe commented Nov 10, 2025

The failing CI here is a combination of a bug in the astropy release candidate (astropy/astropy#18866, already fixed in main) and a pip bug intended behavior change that installed the rc without the --pre option being given pypa/pip#13646

Copy link
Copy Markdown
Contributor

@mexanick mexanick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the test failure is unrelated (astroquery). Can it be related to #2884?

@maxnoe
Copy link
Copy Markdown
Member Author

maxnoe commented Nov 11, 2025

I don't think so, it seems to be a temporary issue with the data serve rnot returning any result

@ctao-sonarqube
Copy link
Copy Markdown

@maxnoe maxnoe merged commit 9c9c6d0 into main Nov 12, 2025
41 of 58 checks passed
@maxnoe maxnoe deleted the eventio2-compat branch November 12, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants