Turn UnclosedFileWarning into error, fix

docs/api-reference/io/index.rst

@@ -200,9 +200,9 @@ into one big table, joining the simulation information if available:
 
     from ctapipe.io import TableLoader
 
-    loader = TableLoader("events.dl1.h5")
-    events = loader.read_subarray_events()
-    tel_events = loader.read_telescope_events()
+    with TableLoader("events.dl1.h5") as loader:
+        events = loader.read_subarray_events()
+        tel_events = loader.read_telescope_events()
 
     print(loader.subarray, len(events), len(tel_events))
 

pyproject.toml

@@ -159,6 +159,7 @@ filterwarnings = [
     "error::ctapipe.utils.deprecation.CTAPipeDeprecationWarning",
     "error::ctapipe.instrument.FromNameWarning",
     "error::ctapipe.core.traits.NoneDefaultNotAllowedWarning",
+    "error::tables.UnclosedFileWarning",
     "ignore:`np.MachAr` is deprecated:DeprecationWarning",
     "ignore::ctapipe.core.provenance.MissingReferenceMetadata",
 ]

src/ctapipe/core/tool.py

@@ -558,6 +558,13 @@ def _repr_html_(self):
 
         return "\n".join(lines)
 
+    def __enter__(self):
+        self._exit_stack.__enter__()
+        return self
+
+    def __exit__(self, exc_value, exc_type, traceback):
+        return self._exit_stack.__exit__(exc_value, exc_type, traceback)
+
 
 def export_tool_config_to_commented_yaml(tool_instance: Tool, classes=None):
     """

src/ctapipe/tools/tests/test_process.py

@@ -53,7 +53,10 @@ def test_read_yaml_toml_json_config(dl1_image_file, config_files):
 
     tool.config.EventSource.input_url = dl1_image_file
     tool.config.DataWriter.overwrite = True
-    tool.setup()
+
+    with tool:
+        tool.setup()
+
     assert (
         tool.get_current_config()["ProcessorTool"]["DataWriter"]["contact_info"].name
         == "YOUR-NAME-HERE"
@@ -69,7 +72,9 @@ def test_multiple_configs(dl1_image_file):
 
     tool.config.EventSource.input_url = dl1_image_file
     tool.config.DataWriter.overwrite = True
-    tool.setup()
+
+    with tool:
+        tool.setup()
 
     # ensure the overwriting works (base config has this option disabled)
     assert tool.get_current_config()["ProcessorTool"]["DataWriter"]["write_dl2"] is True