Add proper typing support for Container fields#2994
Merged
Conversation
maxnoe
force-pushed
the
container-typing
branch
3 times, most recently
from
77ffdcf to
b3de024
Compare
maxnoe
force-pushed
the
container-typing
branch
from
b3de024 to
16e7a92
Compare
|
kosack
approved these changes
Apr 16, 2026
mexanick
approved these changes
Apr 17, 2026
Contributor
mexanick
left a comment
mexanick
left a comment
There was a problem hiding this comment.
thanks, great QoL improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With e.g. pyright installed in an IDE:
Before:
Now:
And e.g. in
CameraCalibrator:Before:
Now:
It cannot deduce the type of the
Map, but that can be explicitly type hinted as well later.