Skip to content

Exclude lst1 dl1 merged#129

Open
aleberti wants to merge 2 commits into
masterfrom
exclude_lst1_dl1_merged
Open

Exclude lst1 dl1 merged#129
aleberti wants to merge 2 commits into
masterfrom
exclude_lst1_dl1_merged

Conversation

@aleberti
Copy link
Copy Markdown
Collaborator

@aleberti aleberti commented Dec 5, 2022

Closes #128.

@aleberti
Copy link
Copy Markdown
Collaborator Author

aleberti commented Dec 5, 2022

I checked that the script exits if run over a DL1 merged files, while it will run as before for subrun files.

Copy link
Copy Markdown
Collaborator

@YoshikiOhtani YoshikiOhtani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alessio, thanks for the implementation, and it looks fine to me. One small suggestion is to put the code inside the event_coincidence function for a safe side, so that it also stops when one directly executes it.

@YoshikiOhtani
Copy link
Copy Markdown
Collaborator

Yukiho started the MAGIC-LST analysis and encountered the same problem. I think we should merge it, as my comments are very minor one. Do you agree, @aleberti?

@YoshikiOhtani YoshikiOhtani self-requested a review June 16, 2023 09:45
@jsitarek
Copy link
Copy Markdown
Collaborator

jsitarek commented Mar 7, 2025

this was never merged. The coincidence code evolved a bit from the time it was implemented, so I am not sure if the original memory problem is still there, but I guess so, because there is still this line with a 2D table of MAGIC vs LST events. In the automatic pipeline we run coincidence over subruns
If nobody complains until next week, I will merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory issues when running event coincidence on merged LST-1 DL1 files

3 participants