Add Bokeh interface for the DQM of NectaRTA#272
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
- Coverage 51.43% 45.98% -5.46%
==========================================
Files 84 89 +5
Lines 7160 8538 +1378
==========================================
+ Hits 3683 3926 +243
- Misses 3477 4612 +1135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Hi @JulianHamo !
Thank you very much for this pull request ! The test app works beautifully !
I did not go through the whole code yet, but from a quick look, it is very well written. I wish I was as proficient with Bokeh as you !
I already left a couple of comments which may require some discussion, I guess.
There was a problem hiding this comment.
As a general rule, we should avoid having data files in the git repo (see e.g. https://www.reddit.com/r/mlops/comments/13s716f/give_me_one_good_reason_why_i_shouldnt_keep_my/).
There was a problem hiding this comment.
I am not sure I can create fake data as my test tries the whole interface at once. This means that I check that my whole pipeline is working, from reading .h5 files to displaying all the data available in DL files.
How should I proceed (maybe when such RTA data will be available on the GRID, I can download some test file from here each time the tests are ran)?
Added instructions for running the test suite and clarified the command for running the Bokeh app.
jlenain
left a comment
There was a problem hiding this comment.
Hi @JulianHamo,
Thank you very much for this pull request! And sorry it took so much time on my side for the review.
Concerning the embedded example file, shall we try to move them to the dedicated test server at CC-IN2P3 ? In such a case, is the code easily adaptable to make use of the ctapipe.utils.get_dataset_path method ?
|
Hi @jlenain, |
Hi @JulianHamo, Absolutely no problem! |
e0f8646 to
0697742
Compare
Summary
This adds the retrieval of RTA files for NectarCAM and their display via a Bokeh webpage for data quality monitoring.
Motivation
Real-time analysis will be processed on on-site servers. This interface is to be run locally so that shifters can access the received data in real time. It is a similar but independent instance of the existing DQM of nectarchain.
Functionalities
Testing
The
tests/test.pydirectory starts the interface using example data (collected in 2025 at CEA).Current use
The current README explains how to use the interface.
Next steps