IRAP Test Bench Converter#301
Conversation
…adable waveformscontainers and chargescontainers
…iner formats. (second push because wrong coding standard used)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 48.95% 49.34% +0.38%
==========================================
Files 85 85
Lines 7731 7796 +65
==========================================
+ Hits 3785 3847 +62
- Misses 3946 3949 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| import matplotlib.style as mplstyle | ||
| import numpy as np | ||
| import pyqtgraph as pg | ||
| import pyqtgraph.exporters |
There was a problem hiding this comment.
Hi @Cormed-Mack !
Sorry, but this should not be needed, as the exporters submodule is used through pg.exporters.ImageExprter in line 1092.
Did you get an error here ?
jlenain
left a comment
There was a problem hiding this comment.
Hi @Cormed-Mack ,
Thanks a lot for this PR, almost ready to be accepted. I just left one comment about your change inspe_algorithm.py, I am not sure it is needed.
|
Just one note also, for future PR, could you please develop in a separate branch in your fork ? The Otherwise, when one wants to contribute, one first has to delete their own local Many thanks ! |
user script containing a tool used to convert IRAP test bench data to nectarchain waveform and charge container objects to be used with nectarchain tools.