Skip to content

IRAP Test Bench Converter#301

Open
Cormed-Mack wants to merge 12 commits into
cta-observatory:mainfrom
Cormed-Mack:main
Open

IRAP Test Bench Converter#301
Cormed-Mack wants to merge 12 commits into
cta-observatory:mainfrom
Cormed-Mack:main

Conversation

@Cormed-Mack
Copy link
Copy Markdown
Contributor

user script containing a tool used to convert IRAP test bench data to nectarchain waveform and charge container objects to be used with nectarchain tools.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.34%. Comparing base (1d9539b) to head (38ba6d1).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   48.95%   49.34%   +0.38%     
==========================================
  Files          85       85              
  Lines        7731     7796      +65     
==========================================
+ Hits         3785     3847      +62     
- Misses       3946     3949       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

import matplotlib.style as mplstyle
import numpy as np
import pyqtgraph as pg
import pyqtgraph.exporters
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Cormed-Mack !
Sorry, but this should not be needed, as the exporters submodule is used through pg.exporters.ImageExprter in line 1092.
Did you get an error here ?

Copy link
Copy Markdown
Collaborator

@jlenain jlenain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Cormed-Mack ,

Thanks a lot for this PR, almost ready to be accepted. I just left one comment about your change inspe_algorithm.py, I am not sure it is needed.

@jlenain jlenain added the enhancement New feature or request label Apr 30, 2026
@jlenain
Copy link
Copy Markdown
Collaborator

jlenain commented Apr 30, 2026

Just one note also, for future PR, could you please develop in a separate branch in your fork ? The main branch should be used as read-only, in the development workflow that we use.

Otherwise, when one wants to contribute, one first has to delete their own local main branch 😱, checkout the other developer's main branch with git checkout --track <ANOTHER_REMOTE>/main, work from there, and then remove again the local main branch 😰 and restore their own with git checkout --track origin/main 😅.

Many thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants