Skip to content

Pixels vals histograms and vs ids shown for all camera displays #307

Merged
jlenain merged 4 commits into
cta-observatory:mainfrom
alessandromontanari:bokeh-camera-vals-vs-pixels-and-histograms
Apr 29, 2026
Merged

Pixels vals histograms and vs ids shown for all camera displays #307
jlenain merged 4 commits into
cta-observatory:mainfrom
alessandromontanari:bokeh-camera-vals-vs-pixels-and-histograms

Conversation

@alessandromontanari
Copy link
Copy Markdown
Contributor

feat(src/nectarchain/dqm/bokeh_app):

  • app_hooks.py: implement make_pixels_vals_histo() with stats and make_pixel_val_vs_id() added to make_camera_displays(); update update_camera_displays() and update_timelines() for the frontend output; remove reset of camera displays and timelines when updating to new run -- obsolete
  • main.py: adapt layouts to accommodate more plots in rows

- app_hooks.py: implement make_pixels_vals_histo() with stats and make_pixel_val_vs_id() added to make_camera_displays(); update update_camera_displays() and update_timelines() for the frontend output; remove reset of camera displays and timelines when updating to new run -- obsolete

- main.py: adapt layouts to accomodate more plots in rows
@alessandromontanari
Copy link
Copy Markdown
Contributor Author

The tests still need to be updated with these changes: I'm on it...

- tests/test_app_hooks.py: adapt tests with new additions on the app_hooks.py
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 86.07595% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.36%. Comparing base (1d9539b) to head (65834c6).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/nectarchain/dqm/bokeh_app/app_hooks.py 89.04% 8 Missing ⚠️
src/nectarchain/dqm/bokeh_app/main.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   48.95%   49.36%   +0.40%     
==========================================
  Files          85       85              
  Lines        7731     7793      +62     
==========================================
+ Hits         3785     3847      +62     
  Misses       3946     3946              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- app_hooks.py: remove production of pixel vals vs id and histogram for bad pixels camera plots

- main.py: adapt layout
- tests/test_app_hooks.py: refactor test to include case with bad pixels camera display
@jlenain jlenain self-requested a review April 29, 2026 08:38
@jlenain jlenain added the enhancement New feature or request label Apr 29, 2026
Copy link
Copy Markdown
Collaborator

@jlenain jlenain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @alessandromontanari !
Just a curiosity we just discussed and I can't understand, I just stumbled across a particular case (run 420 with the QM camera) for which some camera displays are empty, but the histogram and scatter plot show some data. Just some meat for thought for later.

@jlenain jlenain merged commit 0f154b5 into cta-observatory:main Apr 29, 2026
22 of 27 checks passed
@jlenain jlenain deleted the bokeh-camera-vals-vs-pixels-and-histograms branch April 29, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants