Pixels vals histograms and vs ids shown for all camera displays #307
Merged
jlenain merged 4 commits intoApr 29, 2026
Merged
Conversation
- app_hooks.py: implement make_pixels_vals_histo() with stats and make_pixel_val_vs_id() added to make_camera_displays(); update update_camera_displays() and update_timelines() for the frontend output; remove reset of camera displays and timelines when updating to new run -- obsolete - main.py: adapt layouts to accomodate more plots in rows
Contributor
Author
|
The tests still need to be updated with these changes: I'm on it... |
- tests/test_app_hooks.py: adapt tests with new additions on the app_hooks.py
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
+ Coverage 48.95% 49.36% +0.40%
==========================================
Files 85 85
Lines 7731 7793 +62
==========================================
+ Hits 3785 3847 +62
Misses 3946 3946 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- app_hooks.py: remove production of pixel vals vs id and histogram for bad pixels camera plots - main.py: adapt layout
- tests/test_app_hooks.py: refactor test to include case with bad pixels camera display
jlenain
approved these changes
Apr 29, 2026
Collaborator
jlenain
left a comment
There was a problem hiding this comment.
Thanks a lot, @alessandromontanari !
Just a curiosity we just discussed and I can't understand, I just stumbled across a particular case (run 420 with the QM camera) for which some camera displays are empty, but the histogram and scatter plot show some data. Just some meat for thought for later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(src/nectarchain/dqm/bokeh_app):