Skip to content

Add OSGI module name#3

Merged
mpkorstanje merged 3 commits into
mainfrom
add-osgi-module-name
Jan 14, 2026
Merged

Add OSGI module name#3
mpkorstanje merged 3 commits into
mainfrom
add-osgi-module-name

Conversation

@mpkorstanje
Copy link
Copy Markdown
Member

@mpkorstanje mpkorstanje commented Jan 13, 2026

🤔 What's changed?

Add OSGI module name to support

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

It looks like OSGI doesn't work with shaded dependencies. How do we fix that?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje
Copy link
Copy Markdown
Member Author

@laeubi this doesn't work as expected when using the shade plugin. The Import-Package includes com.fasterxml.* which we shaded:

Export-Package: io.cucumber.messages.ndjson;uses:="io.cucumber.messages,
 io.cucumber.messages.types";version="0.2.1"
Import-Package: com.fasterxml.jackson.annotation;version="[2.20,3)",com.
 fasterxml.jackson.core;version="[2.20,3)",com.fasterxml.jackson.databin
 d;version="[2.20,3)",com.fasterxml.jackson.databind.cfg;version="[2.20,
 3)",com.fasterxml.jackson.databind.json;version="[2.20,3)",com.fasterxm
 l.jackson.datatype.jdk8;version="[2.20,3)",com.fasterxml.jackson.module
 .paramnames;version="[2.20,3)",io.cucumber.messages;version="[31.2,32)"
 ,io.cucumber.messages.types;version="[31.2,32)",java.io,java.lang,java.
 util

@laeubi
Copy link
Copy Markdown
Contributor

laeubi commented Jan 13, 2026

@mpkorstanje you should be able to set property

<osgi.import-package>!com.fasterxml.jackson.*, *</osgi.import-package>

Comment thread java/pom.xml
mpkorstanje and others added 2 commits January 14, 2026 15:00
Co-authored-by: Christoph Läubrich <mail@laeubi-soft.de>
@mpkorstanje mpkorstanje marked this pull request as ready for review January 14, 2026 14:02
@mpkorstanje mpkorstanje merged commit 9d5c82d into main Jan 14, 2026
2 checks passed
@mpkorstanje mpkorstanje deleted the add-osgi-module-name branch January 14, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants