Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New card transaction type #106

Merged
merged 2 commits into from
Mar 6, 2021
Merged

New card transaction type #106

merged 2 commits into from
Mar 6, 2021

Conversation

chiqeen03
Copy link
Contributor

@chiqeen03 chiqeen03 commented Feb 26, 2021

Adding new card transaction type to change fast_funds to push type.
We will remove the fast_funds type once the transactions are changed in the Core database and in the Oaxaca db. #112

closes #105

@chiqeen03 chiqeen03 added the enhancement New feature or request label Feb 26, 2021
@chiqeen03 chiqeen03 self-assigned this Feb 26, 2021
@alexviquez
Copy link
Member

Tiene un conflicto con la versión, para que es push?

@alexviquez
Copy link
Member

puedes dar un poco más de contexto

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #106 (57152e9) into main (729d226) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          327       328    +1     
=========================================
+ Hits           327       328    +1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cuenca_validations/types/enums.py 100.00% <100.00%> (ø)
cuenca_validations/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729d226...57152e9. Read the comment docs.

@chiqeen03 chiqeen03 requested a review from alexviquez March 5, 2021 22:10
@alexviquez alexviquez merged commit 20d287b into main Mar 6, 2021
@alexviquez alexviquez deleted the push_type branch March 6, 2021 00:45
agarrido19 pushed a commit that referenced this pull request Mar 7, 2022
* New type and version

* Version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add push ct type
2 participants