dlc-1140 enable fulltext on Carnegie site #225
Conversation
| end | ||
|
|
||
| it 'only includes the field values in facet.field' do | ||
| expect(config.search_fields['fulltext_tesim']).to be_a Blacklight::Configuration::SearchField |
There was a problem hiding this comment.
A background info question: if the flag was not working as expected, what value would config.search_fields['fulltext_tesim'] return?
There was a problem hiding this comment.
hmm if the default was not working it would presumably be nil. It's an added feature here that only applies in two contexts: the Carnegie site and the Carnegie Centennial site; the latter shares all of the configuration except the fulltext field. Semantically it seemed preferable to have the explicit behavior be to suppress the fulltext option.
| described_class.configure(config, fulltext: false) | ||
| end | ||
|
|
||
| it 'only includes the field values in facet.field' do |
There was a problem hiding this comment.
did you intend for this test to also say that it 'only includes the field values in facet.field' or was that a copy error?
There was a problem hiding this comment.
Aargh! I'll fix this in a separate commit.
https://dlc-staging.library.columbia.edu/carnegie?search_field=fulltext_tesim&q=annual+report