Refactoring of inbound argument parsing [TO BE TESTED]#3
Open
GioCC wants to merge 15 commits intocuriosity-workshop:mainfrom
Open
Refactoring of inbound argument parsing [TO BE TESTED]#3GioCC wants to merge 15 commits intocuriosity-workshop:mainfrom
GioCC wants to merge 15 commits intocuriosity-workshop:mainfrom
Conversation
Avoid code duplication by introducing _seekParm() aux function
GioCC
added
Refactoring
Owner
|
Makes sense. Any significant performance impacts anticipated? |
Collaborator
Author
|
Not really, either positive or negative. Mainly, less code clutter and lower chance of bugs in case of modifications (and maybe a little gain in flash space). |
added 2 commits
June 2, 2023 17:26
… #beta-testers-20230601 18:40)
Added functions Xdtostrf (replaces 'dtostrf' lib fn for non-AVR), _receiveNSerial Mods introduced in Discord post https://discord.com/channels/1062448359434113166/1092591510752612362/1192209314857893909
Internal "XPLPro" folders added for file groups Demos moved under Arduino project (as per library convention)
https://discord.com/channels/1062448359434113166/1232263015123128413/1240878122077782066 Added datarefTouch(dataref) function; var types refactored
https://discord.com/channels/1062448359434113166/1262462760512524432/1262462760512524432 - XP.setDataFlowSpeed(1000); // max bytes per second plugin will send - Library now sends data type in the inStruct. It follows the native xplane format - fixed plugin bug with data types for comparing - in Serial log unprintable characters now are represented by their hex value (0xXX) void dataFlowPause(void); // Mostly for internal use but can be useful if your device is busy updating a display screen or whatever void dataFlowResume(void); int getBufferStatus(void); // returns number of bytes in receive buffer void setDataFlowSpeed(unsigned long int); // Set max bytes to send per second. The plugin will always send a complete packet then wait until the time catches up (in terms of flight loops) so take that into consideration. - when requesting updates to data datarefs, specify the maximum digits to return in the precision specifier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids code duplication by introducing _seekParm() auxiliary function