test: fix broken unitary tests #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertoCentonze
force-pushed
the
unitary-tests-fix
branch
from
d3ca235 to
1ee4d95
Compare
AlbertoCentonze
force-pushed
the
simplify-ci
branch
4 times, most recently
from
fa69587 to
cfbb693
Compare
AlbertoCentonze
force-pushed
the
unitary-tests-fix
branch
from
1ee4d95 to
5a6db2c
Compare
AlbertoCentonze
force-pushed
the
unitary-tests-fix
branch
2 times, most recently
from
5dd6a35 to
5ff045d
Compare
AlbertoCentonze
force-pushed
the
unitary-tests-fix
branch
2 times, most recently
from
4fec228 to
6d1426f
Compare
AlbertoCentonze
force-pushed
the
simplify-ci
branch
2 times, most recently
from
0a856d0 to
00da527
Compare
AlbertoCentonze
force-pushed
the
unitary-tests-fix
branch
from
6d1426f to
1d13744
Compare
Macket
reviewed
Dec 9, 2025
Macket
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating unitary tests to respect our testing convention (will be clearly defined and enforced by #105).
test_admin_percentage.pyandtest_collect_fees.pygot moved to thecontrollerfolder as there is no logic specific to the lending one anymore.test_internal_collect_fees.pynow actually tests stuff (was missing a sanity check and was testing absolutely nothing).test_borrowed_balance_lc.pygot renamed totest_available_balance.pyto follow the new method name, also it doesn't need to testprocessas the variable doesn't exist anymore.test_borrow_more_lc.pyandtest_create_loan_lc.pyas there is no lend controller specific code anymore.test_set_admin_fee_lc.vpyrequired a trivial fix due to renaming.test_preview_redeem_v.py/test_preview_withdraw_v.pynow have only one branch to cover.test_set_admin_fee_lc.pygot a trivial renaming fix.This is part 2 of 2 in a stack made with GitButler: