test: fix nested structs

cusma · Feb 4, 2025 · 3c4702a · 3c4702a
1 parent d4e152d
commit 3c4702a
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 35 deletions.
diff --git a/tests/fixed_coupon_bond/test_get_coupon_status.py b/tests/fixed_coupon_bond/test_get_coupon_status.py
@@ -29,9 +29,8 @@ def test_pass_get_coupon_status(
         == fixed_coupon_bond_cfg.time_events[sc_cfg.FIRST_COUPON_DATE_IDX]
     )
     assert coupon_status.all_due_coupons_paid
-    # FIXME: app client has a bug in decoding nested struct
-    # assert coupon_status.day_count_factor.numerator == 0
-    # assert coupon_status.day_count_factor.denominator == 0
+    assert coupon_status.day_count_factor.numerator == 0
+    assert coupon_status.day_count_factor.denominator == 0
 
     for coupon in range(1, fixed_coupon_bond_cfg.total_coupons + 1):
         next_coupon_date_idx = sc_cfg.FIRST_COUPON_DATE_IDX - 1 + coupon
@@ -57,11 +56,10 @@ def test_pass_get_coupon_status(
         else:
             assert not coupon_status.next_coupon_due_date
         assert not coupon_status.all_due_coupons_paid
-        # FIXME: app client has a bug in decoding nested struct
-        # assert (
-        #     coupon_status.day_count_factor.numerator
-        #     == coupon_status.day_count_factor.denominator // coupon_period_fraction
-        # )
+        assert (
+            coupon_status.day_count_factor.numerator
+            == coupon_status.day_count_factor.denominator // coupon_period_fraction
+        )
 
         fixed_coupon_bond_client_primary.send.pay_coupon(
             PayCouponArgs(holding_address=account.holding_address, payment_info=b""),
@@ -80,11 +78,10 @@ def test_pass_get_coupon_status(
         else:
             assert not coupon_status.next_coupon_due_date
         assert coupon_status.all_due_coupons_paid
-        # FIXME: app client has a bug in decoding nested struct
-        # assert (
-        #     coupon_status.day_count_factor.numerator
-        #     == coupon_status.day_count_factor.denominator // coupon_period_fraction
-        # )
+        assert (
+            coupon_status.day_count_factor.numerator
+            == coupon_status.day_count_factor.denominator // coupon_period_fraction
+        )
 
 
 def test_pass_not_configured(

diff --git a/tests/perpetual_bond/test_get_coupon_status.py b/tests/perpetual_bond/test_get_coupon_status.py
@@ -29,9 +29,8 @@ def test_pass_get_coupon_status(
     assert not coupon_status.due_coupons
     assert coupon_status.next_coupon_due_date == issuance_date + coupon_period
     assert coupon_status.all_due_coupons_paid
-    # FIXME: app client has a bug in decoding nested struct
-    # assert coupon_status.day_count_factor.numerator == 0
-    # assert coupon_status.day_count_factor.denominator == 0
+    assert coupon_status.day_count_factor.numerator == 0
+    assert coupon_status.day_count_factor.denominator == 0
 
     for coupon in range(1, DUE_COUPONS + 1):
         coupon_due_date = issuance_date + coupon_period * coupon
@@ -46,11 +45,10 @@ def test_pass_get_coupon_status(
         assert coupon_status.due_coupons == coupon
         assert coupon_status.next_coupon_due_date == coupon_due_date + coupon_period
         assert not coupon_status.all_due_coupons_paid
-        # FIXME: app client has a bug in decoding nested struct
-        # assert (
-        #     coupon_status.day_count_factor.numerator
-        #     == coupon_status.day_count_factor.denominator // coupon_period_fraction
-        # )
+        assert (
+            coupon_status.day_count_factor.numerator
+            == coupon_status.day_count_factor.denominator // coupon_period_fraction
+        )
 
         perpetual_bond_client_primary.send.pay_coupon(
             PayCouponArgs(
@@ -66,11 +64,10 @@ def test_pass_get_coupon_status(
         assert coupon_status.due_coupons == coupon
         assert coupon_status.next_coupon_due_date == coupon_due_date + coupon_period
         assert coupon_status.all_due_coupons_paid
-        # FIXME: app client has a bug in decoding nested struct
-        # assert (
-        #     coupon_status.day_count_factor.numerator
-        #     == coupon_status.day_count_factor.denominator // coupon_period_fraction
-        # )
+        assert (
+            coupon_status.day_count_factor.numerator
+            == coupon_status.day_count_factor.denominator // coupon_period_fraction
+        )
 
 
 def test_pass_not_configured(

diff --git a/tests/zero_coupon_bond/test_get_account_units_current_value.py b/tests/zero_coupon_bond/test_get_account_units_current_value.py
@@ -30,9 +30,8 @@ def test_account_units_value_during_primary(
         == account.principal * (sc_cst.BPS - state.principal_discount) // sc_cst.BPS
     )
     assert value.accrued_interest == 0
-    # FIXME: app client has a bug in decoding nested struct
-    # assert not value.day_count_factor.numerator
-    # assert not value.day_count_factor.denominator
+    assert not value.day_count_factor.numerator
+    assert not value.day_count_factor.denominator
 
 
 def test_account_units_value_at_issuance(
@@ -67,9 +66,8 @@ def test_account_units_value_at_issuance(
         == account.principal * (sc_cst.BPS - state.principal_discount) // sc_cst.BPS
     )
     assert value.accrued_interest == 0
-    # FIXME: app client has a bug in decoding nested struct
-    # assert value.day_count_factor.numerator == 0
-    # assert value.day_count_factor.denominator == maturity_period
+    assert value.day_count_factor.numerator == 0
+    assert value.day_count_factor.denominator == maturity_period
 
 
 def test_account_units_value_at_maturity(
@@ -95,9 +93,8 @@ def test_account_units_value_at_maturity(
     print(value.__dict__)
     assert value.units_value == account.principal
     assert value.accrued_interest == 0
-    # FIXME: app client has a bug in decoding nested struct
-    # assert value.day_count_factor.numerator == 0
-    # assert value.day_count_factor.denominator == 0
+    assert value.day_count_factor.numerator == 0
+    assert value.day_count_factor.denominator == 0
 
 
 def test_fail_no_primary_distribution() -> None: