Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: converting some tests to v3 #21

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

aorumbayev
Copy link

This converts some additional set of tests to v3 - too many tweaks so please just merge and continue from there, first 44 tests should work with these changes (mostly only covered the base contract).

Also note that to have the code working this will require:
algorandfoundation/algokit-client-generator-py#35
algorandfoundation/algokit-utils-py#132

So once above prs are merged and there are bumps in beta versions you'd need to update the dependencies and regenerate contracts -> then continue with remaining abstractions and feel free to report any further issues

tests/base_d_asa/test_open_account.py Outdated Show resolved Hide resolved
tests/base_d_asa/test_open_account.py Outdated Show resolved Hide resolved
tests/base_d_asa/conftest.py Outdated Show resolved Hide resolved
tests/base_d_asa/conftest.py Outdated Show resolved Hide resolved
tests/base_d_asa/conftest.py Outdated Show resolved Hide resolved
tests/base_d_asa/conftest.py Show resolved Hide resolved
tests/base_d_asa/test_asset_update.py Outdated Show resolved Hide resolved
tests/base_d_asa/test_open_account.py Outdated Show resolved Hide resolved
tests/base_d_asa/test_open_account.py Outdated Show resolved Hide resolved
@cusma cusma changed the title Converting some more tests to v3 chore: converting some tests to v3 Jan 31, 2025
@cusma cusma added dependencies Pull requests that update a dependency file tests Improving tests external contribution External contributions welcome labels Jan 31, 2025
Copy link
Owner

@cusma cusma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments. A couple of requests:

  1. You should update ARC-56 in this doc file as well;
  2. You should delete the ARC-32 JSON files.

@cusma cusma merged commit 06debb2 into cusma:chore/algoutils-v3 Jan 31, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file external contribution External contributions welcome tests Improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants