Remove consensus_replicas field from backup#10294
Open
Conversation
# Conflicts: # cvat/apps/engine/serializers.py # cvat/schema.yml
Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> Co-authored-by: Kirill Lakhov <kirill.lakhov@cvat.ai>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #10294 +/- ##
===========================================
+ Coverage 73.82% 77.73% +3.91%
===========================================
Files 431 431
Lines 46651 46666 +15
Branches 4218 4218
===========================================
+ Hits 34438 36275 +1837
+ Misses 12213 10391 -1822
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context
Removing
consensus_replicasfield from backups - number of replicas can be determined from list of jobs.Also, small change to
_get_db_jobsto do all ordering on a db side (and also to ensure that segments are ordered by the minimal job id)depends on #10217
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.