Move package declaration from manifest to gradle

cyb3rko · Oct 22, 2022 · da23b18 · da23b18
1 parent d135227
commit da23b18
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 26 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -4,32 +4,9 @@ plugins {
 }
 
 android {
-//    signingConfigs {
-//        Properties properties = new Properties()
-//        properties.load(project.rootProject.file('local.properties').newDataInputStream())
-//
-//        signingConf1 {
-//            storeFile file(properties.getProperty("signing.file"))
-//            storePassword properties.getProperty("signing.password")
-//            keyAlias properties.getProperty("signing.key1.alias")
-//            keyPassword properties.getProperty("signing.key1.password")
-//        }
-//        signingConf2 {
-//            storeFile file(properties.getProperty("signing.file"))
-//            storePassword properties.getProperty("signing.password")
-//            keyAlias properties.getProperty("signing.key2.alias")
-//            keyPassword properties.getProperty("signing.key2.password")
-//        }
-//        signingConf3 {
-//            storeFile file(properties.getProperty("signing.file"))
-//            storePassword properties.getProperty("signing.password")
-//            keyAlias properties.getProperty("signing.key3.alias")
-//            keyPassword properties.getProperty("signing.key3.password")
-//        }
-//    }
+    namespace 'com.cyb3rko.flashdim'
 
     compileSdk 33
-
     defaultConfig {
         applicationId "com.cyb3rko.flashdim"
         minSdk 33
@@ -73,6 +50,29 @@ android {
             enable = false
         }
     }
+//    signingConfigs {
+//        Properties properties = new Properties()
+//        properties.load(project.rootProject.file('local.properties').newDataInputStream())
+//
+//        signingConf1 {
+//            storeFile file(properties.getProperty("signing.file"))
+//            storePassword properties.getProperty("signing.password")
+//            keyAlias properties.getProperty("signing.key1.alias")
+//            keyPassword properties.getProperty("signing.key1.password")
+//        }
+//        signingConf2 {
+//            storeFile file(properties.getProperty("signing.file"))
+//            storePassword properties.getProperty("signing.password")
+//            keyAlias properties.getProperty("signing.key2.alias")
+//            keyPassword properties.getProperty("signing.key2.password")
+//        }
+//        signingConf3 {
+//            storeFile file(properties.getProperty("signing.file"))
+//            storePassword properties.getProperty("signing.password")
+//            keyAlias properties.getProperty("signing.key3.alias")
+//            keyPassword properties.getProperty("signing.key3.password")
+//        }
+//    }
 }
 
 dependencies {

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools"
-    package="com.cyb3rko.flashdim">
+    xmlns:tools="http://schemas.android.com/tools">
 
     <application
         android:name=".App"