Set/reset the world modified flag and 'DEF' fields#6686
Draft
MNikoliCC wants to merge 12 commits intocyberbotics:masterfrom
Draft
Set/reset the world modified flag and 'DEF' fields#6686MNikoliCC wants to merge 12 commits intocyberbotics:masterfrom
MNikoliCC wants to merge 12 commits intocyberbotics:masterfrom
Conversation
…eir initial values when the simulation is reset. The world modified flag is only set when the simulation time is 0 and there is a change between any of the initial and modified values in the'DEF' fields.
omichel
requested changes
Oct 24, 2024
Member
omichel
left a comment
omichel
left a comment
There was a problem hiding this comment.
Source code tests are failing.
Can you fix them?
MNikoliCC
changed the title
lukicdarkoo
reviewed
Oct 25, 2024
| worldCheckTimer->start(500); | ||
| } | ||
|
|
||
| void WbNodeEditor::tryConnectToWorld() { |
Member
There was a problem hiding this comment.
We cannot have a timer here, we need a cleaner solution
…ew Signal When The 'world' Instance Is Created
lukicdarkoo
added
bug
2 tasks
lukicdarkoo
requested changes
Nov 28, 2024
Member
lukicdarkoo
left a comment
lukicdarkoo
left a comment
There was a problem hiding this comment.
We need to find a simpler and more generic solution (to cover not only DEF but other fields as well). Let's pause on this until we figure out a better solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All modified 'DEF' fields are reset to their initial values when the simulation is reset. The world modified flag is only set when the simulation time is 0 and there is a change between any of the initial and modified values in the 'DEF' fields.
Related Issues
Fixes #5225
Tasks