Draft
Conversation
MNikoliCC
added
test sources
omichel
reviewed
Dec 11, 2024
Member
omichel
left a comment
omichel
left a comment
There was a problem hiding this comment.
Just something looking strange. I am surprised the tests passed.
src/webots/nodes/WbRobot.cpp
Outdated
|
|
||
| if (node != this && dynamic_cast<const WbRobot *>(node)) | ||
| const WbRobot *robotNode = dynamic_cast<const WbRobot *>(node); | ||
| if (node != this && robrobotNodeot) |
Contributor
Author
There was a problem hiding this comment.
Thank you for pointing this out
Contributor
Author
|
After reviewing the issue with latest cppcheck, I suggest not to make further changes at this time. Addressing the warnings would require adding const to a large number of methods, which involves verifying that each method does not modify any member variables of the passed object. While it would be possible to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix cpp code to pass the test sources with latest cppcheck.
Tasks
Add the list of tasks of this PR.