[TASK] Event selection should respect archive constraint (refs #6) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ouse#6) In order to be able to display only future or only past events, the archive constraint must be respected in the repository. Furthermore, the datetime constraint for the calendar plugin should only be applied if a month and year is requested so it doesn't interfere with an event list without such restrictions.
|
+1, stumbled opon the same bug/behaviour when we tried using the list action for displaying events records. Would be great to see this patch in the TER version of the extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to display only future or only past events, the
archive constraint must be respected in the repository. Furthermore,
the datetime constraint for the calendar plugin should only be applied
if a month and year is requested so it doesn't interfere with an
event list without such restrictions.