Add custom metrics #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkwmt
force-pushed
the
add-custom-metrics
branch
from
379aac1 to
bf053b0
Compare
zoetrope
reviewed
Jun 24, 2024
controllers/tenant_controller.go
Outdated
| @@ -89,6 +90,7 @@ func (r *TenantReconciler) Reconcile(ctx context.Context, req ctrl.Request) (res | |||
| if err := r.finalize(ctx, tenant); err != nil { | |||
| return ctrl.Result{}, fmt.Errorf("failed to finalize: %w", err) | |||
| } | |||
| r.removeMetrics(tenant) | |||
There was a problem hiding this comment.
Move removeMetrics to before calling controllerutil.RemoveFinalizer in finalize function.
This is because once RemoveFinalizer is called, this code may never be called again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cattage_tenant_healthyandcattage_tenant_unhealthy--skip-publishflag of goreleaser with--skip=publish