Convert e2e to workflow_dispatch #623
Merged
+127
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed checkout of branch after merge in e2e Signed-off-by: kouki <[email protected]>
kmdkuk
force-pushed
the
convert_e2e_to_workflow_dispatch
branch
from
5ab44d5 to
e07f91a
Compare
kmdkuk
changed the title
|
The E2E test for this PR was run manually from local with |
Signed-off-by: kouki <[email protected]>
yamatcha
previously approved these changes
Dec 15, 2023
Signed-off-by: kouki <[email protected]>
yamatcha
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"OWNER", "COLLABORATOR", and "CONTRIBUTOR" comment
/testin the PR, the e2e test is executed.In converting
ci-e2etoworkflow_dispatch, status checks are now updated manually in workflow.usingmyrotvorets/set-commit-status-actionAdded process to ci-e2e to retrieve branches to be tested.
on.pull_request, the post-merge branch was used for testing without the trigger being aware of it, but withon.workflow_dispath, thegithub.refis the branch that was executed and the post-merge branch is not used.The
.on.issue_commentworkflow is not executed until merged into the main branch, so commenting/teston this PR will not execute the e2e test.Signed-off-by: kouki [email protected]