Skip to content

Conversation

@nojima
Copy link
Collaborator

@nojima nojima commented Jun 13, 2025

This PR extracts bug-fix commits from #90.

These commits fixes the following issues:

  1. When a slave node disconnected from master longer than 5 seconds, it clears all data it stores. That is, when a leader election takes more than 5 seconds, all data are lost.
  2. When an error occurred in a name resolution in tcp_connect, yrmcds crushes without retry. This is an issue because we use dynamically created/updated Service resources to connect to the master node on Kubernetes cluster.
  3. When slave cannot to promote to the master, yrmcds outputs too many logs, which are not useful.

@nojima
Copy link
Collaborator Author

nojima commented Jun 13, 2025

CI failed with the following message. We need to remove 20.04 from CI.

This is a scheduled Ubuntu 20.04 retirement. Ubuntu 20.04 LTS runner will be removed on 2025-04-15.

Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymmt2005 ymmt2005 merged commit 0deb48d into master Jun 13, 2025
4 checks passed
@ymmt2005 ymmt2005 deleted the prevent-slave-data-delete branch June 13, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants