Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Make the CLI work on windows #161

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

ShreyPurohit
Copy link
Contributor

Issue Link: Improvement: Make the CLI work on windows

Key changes:

  • Added _normalize_path function to handle platform-specific path normalization
  • Added _normalize_path_str function to ensure consistent forward slash separators in output
  • Added _get_encoding_list function for cross-platform file encoding detection
  • Enhanced Windows symlink handling in _is_safe_symlink
  • Updated file content string generation to use normalized paths
  • Improved file reading with multiple encoding attempts for better cross-platform compatibility
  • Fixed path separator inconsistencies in test outputs

** Additionally, this project would not run on Windows Systems due to setup.py handling Readme File.
Fixed the above as well

@cyclotruc cyclotruc merged commit a2d9dfa into cyclotruc:main Feb 4, 2025
12 checks passed
@cyclotruc
Copy link
Owner

@ShreyPurohit Thanks a lot for your work on this! very happy that we're now officially supporting Windows thanks to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants