-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: (ui-coverage) add examples for protocol-agnostic views and viewFilters #6133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cypress-documentation
|
Project |
cypress-documentation
|
Branch Review |
pattern-agnostic-views
|
Run status |
|
Run duration | 06m 15s |
Commit |
|
Committer | Mark Noonan |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
302
|
View all changes introduced in this branch ↗︎ |
UI Coverage
10.95%
|
|
---|---|
|
2402
|
|
3
|
Accessibility
96.79%
|
|
---|---|
|
1 critical
4 serious
4 moderate
0 minor
|
|
25
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I might like to add some more explainer text, but I think that would make sense across this whole page and should come in a new PR, this correctly documents the current behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Blocking for now as I noticed the related PR for the functionality hasn't merged yet.)
Update UI coverage docs to show examples of specifying views and view patterns without a specific protocol.
See related PR https://github.com/cypress-io/cypress-services/pull/10437