Skip to content

feat: (ui-coverage) add examples for protocol-agnostic views and viewFilters #6133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

astone123
Copy link
Contributor

Update UI coverage docs to show examples of specifying views and view patterns without a specific protocol.

See related PR https://github.com/cypress-io/cypress-services/pull/10437

@astone123 astone123 self-assigned this Mar 26, 2025
@astone123 astone123 requested a review from pstakoun March 26, 2025 20:14
Copy link

cypress bot commented Mar 26, 2025

cypress-documentation    Run #399

Run Properties:  status check passed Passed #399  •  git commit 2e33bb9ad9: Merge branch 'main' into pattern-agnostic-views
Project cypress-documentation
Branch Review pattern-agnostic-views
Run status status check passed Passed #399
Run duration 06m 15s
Commit git commit 2e33bb9ad9: Merge branch 'main' into pattern-agnostic-views
Committer Mark Noonan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 302
View all changes introduced in this branch ↗︎
UI Coverage  10.95%
  Untested elements 2402  
  Tested elements 3  
Accessibility  96.79%
  Failed rules  1 critical   4 serious   4 moderate   0 minor
  Failed elements 25  

@jennifer-shehane jennifer-shehane requested review from marktnoonan and emilyrohrbough and removed request for pstakoun April 17, 2025 19:23
Copy link
Contributor

@marktnoonan marktnoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I might like to add some more explainer text, but I think that would make sense across this whole page and should come in a new PR, this correctly documents the current behavior.

Copy link
Contributor

@marktnoonan marktnoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Blocking for now as I noticed the related PR for the functionality hasn't merged yet.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants