feat: add rule no-debug#216
Merged
jennifer-shehane merged 3 commits intocypress-io:masterfrom Aug 12, 2024
Merged
Conversation
|
|
|
MikeMcC399
suggested changes
Aug 2, 2024
Collaborator
MikeMcC399
left a comment
MikeMcC399
left a comment
There was a problem hiding this comment.
Please add the new rule no-debug to the README table Rules
Contributor
Author
|
Done ✅ |
MikeMcC399
suggested changes
Aug 2, 2024
Collaborator
MikeMcC399
left a comment
MikeMcC399
left a comment
There was a problem hiding this comment.
Sort order of rules needs correcting.
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
MikeMcC399
approved these changes
Aug 6, 2024
Collaborator
MikeMcC399
left a comment
MikeMcC399
left a comment
There was a problem hiding this comment.
Thanks for making the changes!
I tried out the rule on https://github.com/cypress-io/cypress-example-kitchensink and it worked fine.
From my side, this PR is now ready to merge!
jennifer-shehane
approved these changes
Aug 12, 2024
|
🎉 This PR is included in version 3.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
Congratulations on the release of your rule! 🚀 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #74
It's basically a duplicate of
no-pause.