feat: use chromium instead of electron #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looks like tests are failing since they use env variables not available to PRs created from forks. |
erezrokah
commented
Feb 8, 2021
| @@ -22,7 +22,8 @@ | |||
| "dependencies": { | |||
| "debug": "4.1.1", | |||
| "got": "10.7.0", | |||
| "local-web-server": "^4.2.1" | |||
| "local-web-server": "^4.2.1", | |||
| "puppeteer": "^7.0.1" | |||
There was a problem hiding this comment.
This version requires node >=10.18.1 : https://github.com/puppeteer/puppeteer/blob/4e8d074c2f8384a2f283f5edf9ef69c40bd8464f/package.json#L8
There was a problem hiding this comment.
Also probably not the best approach to get a pinned version of a Chromium based browser
|
Let me merge into local branch "download-chromium" to test this locally before releasing. |
bahmutov
added a commit
that referenced
this pull request
Feb 8, 2021
Co-authored-by: Erez Rokah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
Fixes #42
Fixes #58
This is my first PR to the repo so please let me know if I'm doing anything wrong.
An attempt to fix various crashes related to running Electron in a container.
We've been using a similar approach in our Lighthouse plugin and it has been proven to be very stable.