-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): resolve unsupported puppeteer message #343
Conversation
update puppeteer to 19.11.1 updated netlify-cli to 14.4.0
👷 Deploy request for netlify-plugin-cypress pending review.Visit the deploys page to approve it
|
All CI tests fail 🙁 |
5f0aa06
to
2456f85
Compare
I should have read the CONTRIBUTING.md document first before attempting this PR. 🤔 I may be mistaken, but I don't think that I can get this PR to pass CI without being a member of the Cypress Netlify organization as I need to execute I will leave it open as draft for the moment and expect to close it unless somebody from the core team can pick it up. |
There are multiple inter-dependencies so this PR is unsuccessful in resolving the issue: Updating cd tests/config-file
npm run build
It probably needs a complete rework to resolve this issue. The question then is whether it should be based on react-scripts which has not been updated since September 2022. |
This PR wanted to resolve issue #336 ("npm WARN deprecated [email protected]: < 19.4.0 is no longer supported") and updates the dependency puppeteer to the latest 19.x.x version, which is 19.11.1.
(puppeteer 20.0.0 is a breaking change, so this version is not used.)
Furthermore the dependency netlify-cli is updated to 14.4.0. This resolves the issue that
npm ci
would otherwise fail with the message"npm ERR! code EBADPLATFORM"
if puppeteer
18.2.1
,19.4.0
or19.11.1
is installed.jest is updated to 28.1.3, which is necessary after updating puppeteer.
Verification
Execute:
No deprecation warning such as "npm WARN deprecated [email protected]: < 19.4.0 is no longer supported" should appear (although there will be many other deprecation warnings for other dependencies). Then execute
and in a separate terminal window
npm test
The test should be successful.