Chore: Ordering of modules now deterministic in compiled code #5684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the order of modules depended on the ordering of the hashes of instances of ModuleDefinition, which likely depended on run-time addresses. To ensure we generate code deterministically irrespective of run-time addresses, I sort the module definitions by their full name before iterative over them.
robin-aws
reviewed
Aug 12, 2024
robin-aws
approved these changes
Aug 12, 2024
dnezam
added a commit
to dnezam/dafny
that referenced
this pull request
Sep 25, 2024
…dafny-lang#5684)" This reverts commit 299e2c8 as a temporary workaround for the issue described in dafny-lang#5788
dnezam
added a commit
to dnezam/dafny
that referenced
this pull request
Jan 10, 2025
…dafny-lang#5684)" This reverts commit 299e2c8 as a temporary workaround for the issue described in dafny-lang#5788
dnezam
added a commit
to dnezam/dafny
that referenced
this pull request
Feb 25, 2025
…dafny-lang#5684)" This reverts commit 299e2c8 as a temporary workaround for the issue described in dafny-lang#5788
dnezam
added a commit
to dnezam/dafny
that referenced
this pull request
Feb 27, 2025
…dafny-lang#5684)" This reverts commit 299e2c8 as a temporary workaround for the issue described in dafny-lang#5788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the order of modules depended on the ordering of the hashes of instances of ModuleDefinition, which likely depended on run-time addresses. To ensure we generate code deterministically irrespective of run-time addresses, I sort the module definitions by their full name before iterative over them, for the Dafny code generator as it's the only one that might care about it for now.
How has this been tested?
I added a test that was failing without the code change to DafnyCodeGenerator.cs, which tests that modules are emitted alphabetically in Rust.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.