Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at fixing nightly. #6035

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented Jan 10, 2025

What was changed?

  • Remove the <RuntimeIdentifier>$(RUNTIME_IDENTIFIER)</RuntimeIdentifier> property from csproj files that was needed as a workaround but may break things in .NET 8 according to SO
  • Remove references from DafnyDriver to DafnyServer, that prevented publishing correctly with .NET 8
  • Stop publishing DafnyLanguageServer since it's not used directly.

How has this been tested?

Tested by existing tests

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer added the run-deep-tests Tells CI to run all tests label Jan 10, 2025
@keyboardDrummer keyboardDrummer marked this pull request as ready for review January 10, 2025 13:42
@keyboardDrummer keyboardDrummer merged commit 0edf705 into dafny-lang:master Jan 10, 2025
26 of 32 checks passed
@keyboardDrummer keyboardDrummer deleted the nightlyFix branch January 10, 2025 14:21
olivier-aws pushed a commit to olivier-aws/dafny that referenced this pull request Jan 13, 2025
### What was changed?
- Remove the
`<RuntimeIdentifier>$(RUNTIME_IDENTIFIER)</RuntimeIdentifier>` property
from csproj files that was needed as a workaround but may break things
in .NET 8 according to SO
- Remove references from DafnyDriver to DafnyServer, that prevented
publishing correctly with .NET 8
- Stop publishing DafnyLanguageServer since it's not used directly.

### How has this been tested?
Tested by existing tests

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-deep-tests Tells CI to run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants