Delete test for legacy CLI that tests ambiguous behavior #6037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
added
the
run-integration-tests
keyboardDrummer
changed the title
robin-aws
approved these changes
Jan 10, 2025
olivier-aws
pushed a commit
to olivier-aws/dafny
that referenced
this pull request
Jan 13, 2025
### What was changed? The Dafny legacy CLI shows part of a .NET error message as part of it UI. This can not be tested well since the specific error message is not defined as part of .NET, and can be different across .NET versions and platforms. On Windows it returns: `Invalid filename: The value cannot be an empty string. (Parameter 'path')` On other platforms it is: `Invalid filename: The path is empty. (Parameter 'path')` Instead of fixing the legacy CLI to remove the ambiguity, I'm removing the test for that ambiguous behavior since the old CLI is deprecated. ### How has this been tested? Removed a test <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix failing nightly: https://github.com/dafny-lang/dafny/actions/runs/12711494070/job/35434956978
What was changed?
The Dafny legacy CLI shows part of a .NET error message as part of it UI. This can not be tested well since the specific error message is not defined as part of .NET, and can be different across .NET versions and platforms.
On Windows it returns:
Invalid filename: The value cannot be an empty string. (Parameter 'path')On other platforms it is:
Invalid filename: The path is empty. (Parameter 'path')Instead of fixing the legacy CLI to remove the ambiguity, I'm removing the test for that ambiguous behavior since the old CLI is deprecated.
How has this been tested?
Removed a test
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.