Use collection expressions where possible #6079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssomayyajula
approved these changes
Jan 24, 2025
MikaelMayer
reviewed
Jan 24, 2025
| @@ -22,8 +22,9 @@ private void InitializeAttributes() { | |||
| Attributes.ContainsBool(Attributes, "split", ref splitMatch); | |||
| foreach (var c in Cases) { | |||
| if (!Attributes.Contains(c.Attributes, "split")) { | |||
| List<Expression> args = new List<Expression>(); | |||
| args.Add(Expression.CreateBoolLiteral(c.Origin, splitMatch)); | |||
| List<Expression> args = [ | |||
| new List<TypeParameter>(new TypeParameter[] { new TypeParameter(SourceOrigin.NoToken, new Name("arg"), TypeParameter.TPVarianceSyntax.NonVariant_Strict) }), | ||
| new List<MemberDecl>(), attrs, false, null) { | ||
| [ | ||
| .. new TypeParameter[] |
There was a problem hiding this comment.
What is this weird syntax? Am I understanding correctly that we are creating a list from an inline array? Can we just create now the list using [] ?
Comment on lines
+864
to
866
| Bpl.Expr.Literal(0) | ||
| ]; | ||
| // {:subsumption 0} |
There was a problem hiding this comment.
Suggested change
| Bpl.Expr.Literal(0) | |
| ]; | |
| // {:subsumption 0} | |
| // {:subsumption 0} | |
| Bpl.Expr.Literal(0) | |
| ]; |
| ("p2", "Always true."), | ||
| ("p3", "Always true every time."), | ||
| }); | ||
| ", [ |
There was a problem hiding this comment.
Excellent that it also works with named tuples
| @@ -21,7 +21,7 @@ public void TestConcatSequence() { | |||
| Thread t = new Thread(delegate () { | |||
| left.right = null; | |||
| Thread.Sleep(100); // Ensure ComputeElements() does not work immediately | |||
| left.elmts = new List<int>() { 1, 2 }.ToImmutableArray(); | |||
| left.elmts = [.. new List<int>() { 1, 2 }]; | |||
There was a problem hiding this comment.
Suggested change
| left.elmts = [.. new List<int>() { 1, 2 }]; | |
| left.elmts = [1, 2]; |
I hope it works !
|
Remaining comments addressed in #6083 |
keyboardDrummer
added a commit
that referenced
this pull request
Jan 28, 2025
### What was changed? Small code improvements to address comments from #6079 ### How has this been tested? Pure refactoring <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed?
How has this been tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.