Sync: merge main into dev after release#255
Merged
anasdorbani merged 1 commit intodevfrom Mar 10, 2026
Merged
Conversation
… icon to documentation. (#253)
Contributor
There was a problem hiding this comment.
Pull request overview
This sync PR updates the docs UI and Getting Started page to include an Anthropic/Claude provider card and make the shared DocCard component more flexible for optional icon rendering.
Changes:
- Make
DocCard’sIconprop optional and render the icon conditionally. - Add an Anthropic/Claude
DocCardentry to the Getting Started docs page (including theSiAnthropicicon import).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/src/components/global/DocCard.tsx | Refactors props typing and makes icon rendering optional. |
| docs/docs/getting-started/getting-started.md | Adds Anthropic/Claude card and icon import in the provider list. |
Comment on lines
+15
to
23
| <div | ||
| onClick={() => window.open(link, "_self")} | ||
| className="my-2 flex gap-2 cursor-pointer rounded-2xl items-center text-lg font-bold border-solid border-[1px] border-[#FF9128] p-4 hover:shadow-[0_0_10px_#FF9128] hover:shadow-orange-500/50 transition-all duration-300 ease-in-out" | ||
| > | ||
| {Icon && ( | ||
| <Icon className="text-[#FF9128] text-3xl rounded-lg border-solid border-[1px] border-[#FF9128] p-1" /> | ||
| )} | ||
| {title} | ||
| </div> |
There was a problem hiding this comment.
The clickable card is implemented as a
with an onClick handler. This is not keyboard-accessible and lacks proper link/button semantics for screen readers. Consider using an (or Docusaurus ) for navigation, or at minimum add role="link"/"button", tabIndex={0}, and key handlers (Enter/Space) so the card is operable via keyboard.
Suggested change
| <div | |
| onClick={() => window.open(link, "_self")} | |
| className="my-2 flex gap-2 cursor-pointer rounded-2xl items-center text-lg font-bold border-solid border-[1px] border-[#FF9128] p-4 hover:shadow-[0_0_10px_#FF9128] hover:shadow-orange-500/50 transition-all duration-300 ease-in-out" | |
| > | |
| {Icon && ( | |
| <Icon className="text-[#FF9128] text-3xl rounded-lg border-solid border-[1px] border-[#FF9128] p-1" /> | |
| )} | |
| {title} | |
| </div> | |
| <a | |
| href={link} | |
| className="my-2 flex gap-2 cursor-pointer rounded-2xl items-center text-lg font-bold border-solid border-[1px] border-[#FF9128] p-4 hover:shadow-[0_0_10px_#FF9128] hover:shadow-orange-500/50 transition-all duration-300 ease-in-out" | |
| > | |
| {Icon && ( | |
| <Icon className="text-[#FF9128] text-3xl rounded-lg border-solid border-[1px] border-[#FF9128] p-1" /> | |
| )} | |
| {title} | |
| </a> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.