BMW i3: Split up transmit CAN to avoid overloads#2290
Open
dalathegreat wants to merge 2 commits into
Open
Conversation
Collaborator
|
I guess that is very similar to add an else clause in the end of every if-clause in the transmit_can function. Except that else clauses would give higher priority to the first if clauses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR splits up transmit CAN to avoid overloads in the BMW i3 integration
Why
To avoid getting TASK_OVERRUN events
How
Same approach as in #2286
Tip
You can help test this PR with this guide