multiple images upload

[scoder1747]

Summary

This PR allows selecting multiple images option in the Media Picker Sheet. The selected images are uploaded using the default handle_upload() method while performed in an array iteration.

The motivation comes from the fact that it is often tedious to select one image at a time from the sheet and repeat the same process for multiple uploads.

The demo of the feature is attached here:

multipleimagesselecting.mp4

Checklist

• I have read (or I am familiar with) the Contribution Guidelines
• I have tested the changes in this PR
• My PR is either small, or I have split it into smaller logical commits that are easier to review
• I have added the signoff line to all my commits. See Signing off your work
• I have added appropriate changelog entries for the changes in this PR. See Adding changelog entries
  • I do not need to add a changelog entry. Reason: [Please provide a reason]
• I have added appropriate Closes: or Fixes: tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patches

[jb55]

I tried this, but when I selected 2 images the progress bar completed, and it took another 30 seconds for the second image to appear. This was pretty confusing.

[scoder1747]

@jb55 I have addressed the issue you faced in subsequent commits

[jb55]

it works, and I will merge it. I would like to see a followup that ensures the order in which they were clicked. right now its all async and the images come in with random order

[scoder1747]

@jb55 I have resolved the issue about the order in the new commit

[scoder1747]

[jb55]

Awesome, testing again

…

On Oct 15, 2024, at 19:49, Swift ***@***.***> wrote: @jb55 I have resolved the issue about the order in the new commit — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[jb55]

@scoder1747 this adds a ordered indicator but it does not ensure that the order is correct when adding the elements to the note. the order would have to be saved somewhere and then the URLs and URL previews would have to be inserted in the correct locations. We can scope this to another PR though.

I have a feeling this is going to be the biggest complain when we launch this on TestFlight... so we should do it soon