Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for updating timestamp format in .dandi/assets.json #384

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented May 21, 2024

@jwodder jwodder requested a review from yarikoptic May 21, 2024 13:23
@jwodder jwodder changed the title Script for updating timestamp format in .dandi/assets.json Script for updating timestamp format in .dandi/assets.json May 21, 2024
cwd=p,
check=True,
)
to_save.append(p.name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in principle you could avoid "manual" git commit above and just add fpath to to_save and then rely on datalad save to do the right thing to save all those individual files (and their subdatasets).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too late for that now.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

committing/saving could be made into a single datalad save command but otherwise -- should work.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intended to approve, not comment ;-)

@jwodder jwodder merged commit 12ab125 into draft May 21, 2024
1 check passed
@jwodder jwodder deleted the gh-40 branch May 21, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants