Fix #13358: Add 'isFriend' to DumpFile (#7224)

danmar · Jan 17, 2025 · 10bab82 · 10bab82
1 parent bb81a66
commit 10bab82
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lib/symboldatabase.cpp b/lib/symboldatabase.cpp
@@ -4267,6 +4267,8 @@ void SymbolDatabase::printXml(std::ostream &out) const
                         outs += " isInlineKeyword=\"true\"";
                     if (function->isStatic())
                         outs += " isStatic=\"true\"";
+                    if (function->isFriend())
+                        outs += " isFriend=\"true\"";
                     if (function->isAttributeNoreturn())
                         outs += " isAttributeNoreturn=\"true\"";
                     if (const Function* overriddenFunction = function->getOverriddenFunction()) {

diff --git a/test/testsymboldatabase.cpp b/test/testsymboldatabase.cpp
@@ -607,6 +607,8 @@ class TestSymbolDatabase : public TestFixture {
         TEST_CASE(incomplete_type); // #9255 (infinite recursion)
         TEST_CASE(exprIds);
         TEST_CASE(testValuetypeOriginalName);
+
+        TEST_CASE(dumpFriend); // Check if isFriend added to dump file
     }
 
     void array() {
@@ -11073,6 +11075,19 @@ class TestSymbolDatabase : public TestFixture {
             ASSERT(tok->valueType()->constness == 0);
         }
     }
+
+    void dumpFriend() {
+        GET_SYMBOL_DB("class Foo {\n"
+                      "    Foo();\n"
+                      "    int x{};\n"
+                      "    friend bool operator==(const Foo&lhs, const Foo&rhs) {\n"
+                      "        return lhs.x == rhs.x;\n"
+                      "    }\n"
+                      "};");
+        std::ostringstream ostr;
+        db->printXml(ostr);
+        ASSERT(ostr.str().find(" isFriend=\"true\"") != std::string::npos);
+    }
 };
 
 REGISTER_TEST(TestSymbolDatabase)