Fix #12251 internalError while cppcheck tries to parse Clang AST #5755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
reviewed
Dec 12, 2023
| @@ -509,7 +509,7 @@ void clangimport::AstNode::setLocations(TokenList *tokenList, int file, int line | |||
| } else if (ext[0] == '<') { | |||
| const std::string::size_type colon = ext.find(':'); | |||
| if (colon != std::string::npos) { | |||
| const bool windowsPath = colon == 2 && ext.size() > 4 && ext[3] == '\\'; | |||
| const bool windowsPath = colon == 2 && ext.size() > 3 && ext[2] == ':'; | |||
There was a problem hiding this comment.
Some logic for this already exists in Path::isAbsolute() and maybe other places as well. We could put this in a helper function later on and share the code.
There was a problem hiding this comment.
I don't think that would work, since we are already inside a larger string here. We only need to know if there is a second colon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.