Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12790-93 fuzzing crashes #6460

Merged
merged 11 commits into from
May 31, 2024
Merged

Conversation

chrchr-github
Copy link
Collaborator

No description provided.

@chrchr-github
Copy link
Collaborator Author

@firewave Not sure what the script error means. Locally, I get a syntaxError for both samples.

@firewave
Copy link
Collaborator

@firewave Not sure what the script error means. Locally, I get a syntaxError for both samples.

That means the process exited with a non-zero exitcode. We probably need to adjust the test to show stderr if stdout is empty (actually a lot of tests need to do that but that is a cleanup for another time).

@chrchr-github
Copy link
Collaborator Author

@firewave Not sure what the script error means. Locally, I get a syntaxError for both samples.

That means the process exited with a non-zero exitcode.

Ugh, never mind, I had missed some local changes...

@chrchr-github chrchr-github reopened this May 29, 2024
@chrchr-github chrchr-github changed the title Fix #12790-91 fuzzing crashes in TemplateSimplifier::getTemplateInstantiations() Fix #12790-91, #12793 fuzzing crashes May 29, 2024
@chrchr-github chrchr-github marked this pull request as draft May 29, 2024 16:38
@chrchr-github chrchr-github changed the title Fix #12790-91, #12793 fuzzing crashes Fix #12790-93 fuzzing crashes May 29, 2024
@chrchr-github chrchr-github reopened this May 29, 2024
@firewave
Copy link
Collaborator

oom-e19261c78d73cf172308f6c33df68642dfd7b679 is in the wrong folder.

@chrchr-github
Copy link
Collaborator Author

oom-e19261c78d73cf172308f6c33df68642dfd7b679 is in the wrong folder.

Good catch, fixed.

@firewave
Copy link
Collaborator

Please also add the missing Python package:

diff --git a/.github/workflows/asan.yml b/.github/workflows/asan.yml
--- a/.github/workflows/asan.yml	(revision ab9def971a17aa2eb0ecc60a09c514d783834de0)
+++ b/.github/workflows/asan.yml	(date 1717011192127)
@@ -64,6 +64,7 @@
           python3 -m pip install pip --upgrade
           python3 -m pip install pytest
           python3 -m pip install pytest-timeout
+          python3 -m pip install psutil
 
       # TODO: disable all warnings
       - name: CMake
diff --git a/.github/workflows/tsan.yml b/.github/workflows/tsan.yml
--- a/.github/workflows/tsan.yml	(revision ab9def971a17aa2eb0ecc60a09c514d783834de0)
+++ b/.github/workflows/tsan.yml	(date 1717011192131)
@@ -64,6 +64,7 @@
           python3 -m pip install pip --upgrade
           python3 -m pip install pytest
           python3 -m pip install pytest-timeout
+          python3 -m pip install psutil
 
       - name: CMake
         run: |
diff --git a/.github/workflows/CI-unixish.yml b/.github/workflows/CI-unixish.yml
--- a/.github/workflows/CI-unixish.yml	(revision ab9def971a17aa2eb0ecc60a09c514d783834de0)
+++ b/.github/workflows/CI-unixish.yml	(date 1717011129743)
@@ -373,6 +373,7 @@
           python3 -m pip install pip --upgrade
           python3 -m pip install pytest
           python3 -m pip install pytest-timeout
+          python3 -m pip install psutil
 
       - name: Build cppcheck
         run: |
diff --git a/.github/workflows/ubsan.yml b/.github/workflows/ubsan.yml
--- a/.github/workflows/ubsan.yml	(revision ab9def971a17aa2eb0ecc60a09c514d783834de0)
+++ b/.github/workflows/ubsan.yml	(date 1717011192117)
@@ -63,6 +63,7 @@
           python3 -m pip install pip --upgrade
           python3 -m pip install pytest
           python3 -m pip install pytest-timeout
+          python3 -m pip install psutil
 
       # TODO: disable warnings
       - name: CMake
diff --git a/.github/workflows/CI-windows.yml b/.github/workflows/CI-windows.yml
--- a/.github/workflows/CI-windows.yml	(revision ab9def971a17aa2eb0ecc60a09c514d783834de0)
+++ b/.github/workflows/CI-windows.yml	(date 1717011192144)
@@ -132,6 +132,7 @@
           python -m pip install pytest || exit /b !errorlevel!
           python -m pip install pytest-custom_exit_code || exit /b !errorlevel!
           python -m pip install pytest-timeout || exit /b !errorlevel!
+          python -m pip install psutil || exit /b !errorlevel!
 
       - name: Run CMake
         if: false # TODO: enable

@chrchr-github
Copy link
Collaborator Author

Please also add the missing Python package:

What is this and why is it missing? Should that be a seperate PR?

@chrchr-github chrchr-github marked this pull request as ready for review May 29, 2024 20:42
@firewave
Copy link
Collaborator

What is this and why is it missing?

psutil is used to kill the process tree when we encounter a timeout in Python. It is missing because I only tested it locally where that package is installed and we never hit it in the CI. You can see the error of it not being found in the output of the failed build

Should that be a seperate PR?

It can be separate.

@chrchr-github
Copy link
Collaborator Author

Please also add the missing Python package:

Done: #6462

@chrchr-github chrchr-github merged commit 22477ef into danmar:main May 31, 2024
63 checks passed
@chrchr-github chrchr-github deleted the chr_12790 branch May 31, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants