-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #12790-93 fuzzing crashes #6460
Conversation
@firewave Not sure what the script error means. Locally, I get a syntaxError for both samples. |
That means the process exited with a non-zero exitcode. We probably need to adjust the test to show |
Ugh, never mind, I had missed some local changes... |
|
Good catch, fixed. |
Please also add the missing Python package: diff --git a/.github/workflows/asan.yml b/.github/workflows/asan.yml
--- a/.github/workflows/asan.yml (revision ab9def971a17aa2eb0ecc60a09c514d783834de0)
+++ b/.github/workflows/asan.yml (date 1717011192127)
@@ -64,6 +64,7 @@
python3 -m pip install pip --upgrade
python3 -m pip install pytest
python3 -m pip install pytest-timeout
+ python3 -m pip install psutil
# TODO: disable all warnings
- name: CMake
diff --git a/.github/workflows/tsan.yml b/.github/workflows/tsan.yml
--- a/.github/workflows/tsan.yml (revision ab9def971a17aa2eb0ecc60a09c514d783834de0)
+++ b/.github/workflows/tsan.yml (date 1717011192131)
@@ -64,6 +64,7 @@
python3 -m pip install pip --upgrade
python3 -m pip install pytest
python3 -m pip install pytest-timeout
+ python3 -m pip install psutil
- name: CMake
run: |
diff --git a/.github/workflows/CI-unixish.yml b/.github/workflows/CI-unixish.yml
--- a/.github/workflows/CI-unixish.yml (revision ab9def971a17aa2eb0ecc60a09c514d783834de0)
+++ b/.github/workflows/CI-unixish.yml (date 1717011129743)
@@ -373,6 +373,7 @@
python3 -m pip install pip --upgrade
python3 -m pip install pytest
python3 -m pip install pytest-timeout
+ python3 -m pip install psutil
- name: Build cppcheck
run: |
diff --git a/.github/workflows/ubsan.yml b/.github/workflows/ubsan.yml
--- a/.github/workflows/ubsan.yml (revision ab9def971a17aa2eb0ecc60a09c514d783834de0)
+++ b/.github/workflows/ubsan.yml (date 1717011192117)
@@ -63,6 +63,7 @@
python3 -m pip install pip --upgrade
python3 -m pip install pytest
python3 -m pip install pytest-timeout
+ python3 -m pip install psutil
# TODO: disable warnings
- name: CMake
diff --git a/.github/workflows/CI-windows.yml b/.github/workflows/CI-windows.yml
--- a/.github/workflows/CI-windows.yml (revision ab9def971a17aa2eb0ecc60a09c514d783834de0)
+++ b/.github/workflows/CI-windows.yml (date 1717011192144)
@@ -132,6 +132,7 @@
python -m pip install pytest || exit /b !errorlevel!
python -m pip install pytest-custom_exit_code || exit /b !errorlevel!
python -m pip install pytest-timeout || exit /b !errorlevel!
+ python -m pip install psutil || exit /b !errorlevel!
- name: Run CMake
if: false # TODO: enable |
What is this and why is it missing? Should that be a seperate PR? |
It can be separate. |
Done: #6462 |
No description provided.