Fix #4778: FP: Uninitialized variable

[olabetskyi]

No description provided.

[pfultz2]

This check should probably be added to the getExprUsage function so it returns ExprUsage::NotUsed.

[mptre]

This change seem to have introduced a regression.

$ cat fp.c
void
fp(const char *str)
{
        const char *s = str;
        char *end;
        unsigned long val = 0;

        s = end;

        if (1) {
                val = strtoul(&s[1], &end, 10);
                if (val > INT_MAX)
                        return;
        }
}
$ cppcheck --enable=all fp.c
fp.c:11:9: error: Bad indirect value: 3 [internalError]
  val = strtoul(&s[1], &end, 10);
        ^

[chrchr-github]

This change seem to have introduced a regression.

Probably related to dc385f3

[danmar]

@olabetskyi hmm which FP ticket did this solve? It wasn't 4478.

[olabetskyi]

https://trac.cppcheck.net/ticket/4778