-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix emscripten config #6503
Fix emscripten config #6503
Conversation
460b99e
to
0d40e92
Compare
Maybe we should add include detection here: cppcheck/tools/donate_cpu_lib.py Line 680 in dc385f3
|
0d40e92
to
d645b87
Compare
@firewave Should we bump the |
Yes, absolutely. |
Leaving the emscripten macros returning a value empty was leading to syntax errors The pointer returned by `EM_ASM_PTR` must be freed by calling `free` Add emscripten without a syntax check for now as we would need the emscripten tool chain
d645b87
to
d4cadb5
Compare
@firewave, @chrchr-github Sorry I missed the version number in this file. I incremented the patch version now |
According to the discussion in #6461, this needs to be commented out at least until the next release. Sorry for the confusion. |
Yes. In this case it does not need to be disabled. The file was added four years ago and never was fully integrated. |
Leaving the emscripten macros, returning a value, empty was leading to syntax errors
The pointer returned by
EM_ASM_PTR
must be freed by callingfree
seehttps://emscripten.org/docs/api_reference/emscripten.h.html?highlight=em_asm_ptr#c.EM_ASM_PTR