Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 12463: dumpfile: what library are used #6569

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

swasti16
Copy link
Contributor

@swasti16 swasti16 commented Jul 3, 2024

No description provided.

@swasti16 swasti16 force-pushed the swasti/12463 branch 5 times, most recently from 366ddf8 to 2b06bf5 Compare July 3, 2024 13:08
lib/settings.h Outdated Show resolved Hide resolved
test/testcppcheck.cpp Outdated Show resolved Hide resolved
lib/cppcheck.cpp Outdated Show resolved Hide resolved
@swasti16 swasti16 force-pushed the swasti/12463 branch 2 times, most recently from b888d8b to 32ae8ad Compare July 3, 2024 18:22
lib/cppcheck.cpp Outdated Show resolved Hide resolved
@swasti16 swasti16 force-pushed the swasti/12463 branch 3 times, most recently from fd092bc to 5b367d3 Compare July 4, 2024 05:50
@chrchr-github
Copy link
Collaborator

Please rebase, the CI failure has been fixed.

Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

lib/cppcheck.cpp Outdated
std::string CppCheck::getLibraryDumpData() const {
std::string out;
for (const std::string &s : mSettings.libraries) {
out += " <library lib=\"" + s + "\"/>\n";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to me there are 2 spaces between + s not sure why the formatter accepts that.

@danmar danmar merged commit c89574c into danmar:main Jul 12, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants