Partial fix for #12923: syntaxError for valid template declaration #6603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids saving names that appear after the assignment operator within a template parameter declaration.
ehlert-battelle
force-pushed
the
partial-fix-12923
branch
from
8b740b1 to
5ae0525
Compare
|
Thanks for your contribution. How would you like to be credited in the Authors file? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids saving names that appear after the assignment operator within a template parameter declaration.
Note that is only fixes the initial example shown in the ticket description; the other examples in the first comment seem trickier to solve at the moment.